Fixed|libcore|Info: Retain original element names

When converting an Info block to a Record, the created variables use the unmodified letter case of the Info element names. Previously, the lower-cased lookup names were being used. IssueID #2397
skyjake · Jan 7, 2020 · 975a113 · 975a113
1 parent 9eca1f4
commit 975a113
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/doomsday/sdk/libcore/include/de/data/info.h b/doomsday/sdk/libcore/include/de/data/info.h
@@ -248,7 +248,9 @@ class DENG2_PUBLIC Info
         void moveContents(BlockElement &destination);
 
         /**
-         * Converts the contents of the block into a Record.
+         * Converts the contents of the block into a Record. Variables in the record
+         * are named using the unmodified element names (i.e., not lowercased).
+         *
          * @return Record with block elements.
          */
         Record asRecord() const;

diff --git a/doomsday/sdk/libcore/src/data/info.cpp b/doomsday/sdk/libcore/src/data/info.cpp
@@ -813,8 +813,8 @@ Record Info::BlockElement::asRecord() const
     Record rec;
     for (auto i = _contents.begin(); i != _contents.end(); ++i)
     {
-        std::unique_ptr<Variable> var(new Variable(i.key()));
         const Element *elem = i.value();
+        std::unique_ptr<Variable> var(new Variable(elem->name())); // retain case in the name
         if (elem->isBlock())
         {
             var->set(RecordValue::takeRecord(elem->as<BlockElement>().asRecord()));