Skip to content

Commit

Permalink
Fixed|libdeng2: de::Reader was missing a destructor
Browse files Browse the repository at this point in the history
Reader's internal Instance was never freed.
  • Loading branch information
skyjake committed Dec 4, 2012
1 parent 16cd87a commit 99e83ff
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
2 changes: 2 additions & 0 deletions doomsday/libdeng2/include/de/data/reader.h
Expand Up @@ -83,6 +83,8 @@ class DENG2_PUBLIC Reader
*/
Reader(IIStream const &stream, ByteOrder const &byteOrder = littleEndianByteOrder);

virtual ~Reader();

//@{ Read a number from the source buffer, in network byte order.
Reader &operator >> (char &byte);
Reader &operator >> (dchar &byte);
Expand Down
5 changes: 5 additions & 0 deletions doomsday/libdeng2/src/data/reader.cpp
Expand Up @@ -193,6 +193,11 @@ Reader::Reader(IIStream const &stream, ByteOrder const &byteOrder)
: d(new Instance(byteOrder, &stream))
{}

Reader::~Reader()
{
delete d;
}

Reader &Reader::operator >> (char &byte)
{
return *this >> reinterpret_cast<duchar &>(byte);
Expand Down

0 comments on commit 99e83ff

Please sign in to comment.