Fixed: Errors detected by rpmlint

Thanks for the patch jengelh!
skyjake · Jun 12, 2012 · a6b02b8 · a6b02b8
1 parent f2fc6fa
commit a6b02b8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/doomsday/engine/portable/src/generators.c b/doomsday/engine/portable/src/generators.c
@@ -211,7 +211,7 @@ int Generators_IterateList(Generators* gens, uint listIndex,
 {
     listnode_t* it;
     assert(gens);
-    for(it = it = gens->lists[listIndex]; it; it = it->next)
+    for(it = gens->lists[listIndex]; it; it = it->next)
     {
         int result = callback(it->gen, parameters);
         if(result) return result;

diff --git a/doomsday/engine/portable/src/uri.c b/doomsday/engine/portable/src/uri.c
@@ -455,7 +455,7 @@ boolean Uri_Equality(const Uri* uri, const Uri* other)
     }
 }
 
-static writeUri(const ddstring_t* scheme, const ddstring_t* path, Writer* writer)
+static void writeUri(const ddstring_t* scheme, const ddstring_t* path, Writer* writer)
 {
     Str_Write(scheme, writer);
     Str_Write(path, writer);

diff --git a/doomsday/engine/unix/src/sys_console.c b/doomsday/engine/unix/src/sys_console.c
@@ -72,7 +72,7 @@ static int getScreenSize(int axis)
 {
     int                 x, y;
 
-    if(!isValidConsoleWindow(Window_Main())) return;
+    if(!isValidConsoleWindow(Window_Main())) return 0;
 
     getmaxyx(mainConsole.winText, y, x);
     return axis == VX ? x : y;