Skip to content

Commit

Permalink
Hexen|Debug: Cleanup
Browse files Browse the repository at this point in the history 
A fatal error in the mobj saver, oh my. Probably meant to be an
assert? Triggered this when saving the game right after killing
Korax in the end of Hexen.
  • Loading branch information
@skyjake
skyjake committed Mar 26, 2013
1 parent 03b7d61 commit b29b196
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions doomsday/plugins/common/src/p_saveg.c
View file
Expand Up @@ -1763,8 +1763,9 @@ static void SV_WriteMobj(const mobj_t* original)

default:
# if _DEBUG
if(mo->tracer != NULL)
Con_Error("SV_WriteMobj: Mobj using tracer. Possibly saved incorrectly.");
/// @todo Fix this fatal error. -jk

This comment has been minimized.

Sign in to view

Copy link
@danij-deng

danij-deng Mar 26, 2013

Collaborator

I'd like to know more about the circumstances in which this was triggered. For example, had you a servant in play at the time? Were you playing as the Mage? Many years back I spent time pulling apart Hexen to figure out how the special1/2 and tracer values of mobj_t were used for each mobj type. You'll notice the logic switch above deals with the cases I completed tracing logic paths for.

Also, remember that prior to 1.9.7 we didn't really use assert and instead used Con_Error. This code dates back to around 1.9.0 beta 3. Indeed it should be changed to an assert now, however.

This comment has been minimized.

Sign in to view

Copy link
@skyjake

skyjake Mar 27, 2013

Author Owner

See notes: http://pastebin.com/UJ0ER9vg
if(mo->tracer != NULL)
Con_Error("SV_WriteMobj: Mobj using tracer. Possibly saved incorrectly.");
# endif
SV_WriteLong(PTR2INT(mo->tracer));
break;
Expand Down

0 comments on commit b29b196

Please sign in to comment.