Fixed|UI|Client: Closing the window first unloads the game

skyjake · Nov 12, 2016 · ccd2667 · ccd2667
1 parent 5aadede
commit ccd2667
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 9 deletions.
diff --git a/doomsday/apps/client/include/ui/clientwindow.h b/doomsday/apps/client/include/ui/clientwindow.h
@@ -167,9 +167,6 @@ class ClientWindow : public de::BaseWindow
     // Notifications.
     bool isFPSCounterVisible() const;
 
-    // Events.
-    //void closeEvent(QCloseEvent *) override;
-
     // Implements BaseWindow.
     de::Vector2f windowContentSize() const override;
     void drawWindowContent() override;
@@ -185,6 +182,9 @@ public slots:
     void showColorAdjustments();
     void hideTaskBarBlur();
 
+protected:
+    void windowAboutToClose() override;
+
 private:
     DENG2_PRIVATE(d)
 };

diff --git a/doomsday/apps/client/src/ui/clientwindow.cpp b/doomsday/apps/client/src/ui/clientwindow.cpp
@@ -441,8 +441,6 @@ DENG2_PIMPL(ClientWindow)
 
     void windowInit(GLWindow &)
     {
-        qDebug() << "Client: windowInit";
-
         Sys_GLConfigureDefaultState();
         GL_Init2DState();
 
@@ -869,9 +867,23 @@ bool ClientWindow::isGameMinimized() const
     return d->isGameMini;
 }
 
-/*
-void ClientWindow::closeEvent(QCloseEvent *ev)
+void ClientWindow::windowAboutToClose()
 {
+    if (BusyMode_Active())
+    {
+        // Oh well, we can't cancel busy mode...
+        return;
+    }
+
+    // Unload the game currently loaded. This will ensure it is shut down gracefully.
+    if (!DoomsdayApp::game().isNull())
+    {
+        glActivate();
+        BusyMode_FreezeGameForBusyMode();
+        DoomsdayApp::app().changeGame(GameProfiles::null(), DD_ActivateGameWorker);
+    }
+
+#if 0
     if (!BusyMode_Active())
     {
         LOG_DEBUG("Window is about to close, executing 'quit'");
@@ -882,8 +894,9 @@ void ClientWindow::closeEvent(QCloseEvent *ev)
 
     // We are not authorizing immediate closing of the window;
     // engine shutdown will take care of it later.
-    ev->ignore(); // don't close
-}*/
+    return false;
+#endif
+}
 
 void ClientWindow::preDraw()
 {

diff --git a/doomsday/sdk/libgui/include/de/gui/glwindow.h b/doomsday/sdk/libgui/include/de/gui/glwindow.h
@@ -181,6 +181,7 @@ class LIBGUI_PUBLIC GLWindow : public QOpenGLWindow, public Asset
 protected:
     void initializeGL() override;
     void paintGL() override;
+    virtual void windowAboutToClose();
 
     // Native events.
     void resizeEvent            (QResizeEvent *ev) override;

diff --git a/doomsday/sdk/libgui/src/glwindow.cpp b/doomsday/sdk/libgui/src/glwindow.cpp
@@ -335,6 +335,10 @@ bool GLWindow::event(QEvent *ev)
         return QApplication::sendEvent(&canvas(), &keyEvent);
     }
 #endif*/
+    if (ev->type() == QEvent::Close)
+    {
+        windowAboutToClose();
+    }
     return QOpenGLWindow::event(ev);
 }
 
@@ -449,6 +453,9 @@ void GLWindow::paintGL()
     }
 }
 
+void GLWindow::windowAboutToClose()
+{}
+
 void GLWindow::resizeEvent(QResizeEvent *ev)
 {
     d->pendingSize = Size(ev->size().width(), ev->size().height()) * qApp->devicePixelRatio();