Refactor|Map Renderer: Various minor cleanup refactorings

doomsday/client/include/map/line.h

@@ -758,11 +758,11 @@ class Line : public de::MapElement
     /**
      * Change the polyobj attributed to the line.
      *
-     * @param newOwner New polyobj to attribute as the line to. Can be @c 0,
-     *                 to clear the attribution. (Note that the polyobj may
-     *                 also represent this relationship, so the relevant
-     *                 method(s) of Polyobj will also need to be called to
-     *                 complete the job of clearing this relationship.)
+     * @param newPolyobj New polyobj to attribute the line to. Can be @c 0,
+     *                   to clear the attribution. (Note that the polyobj may
+     *                   also represent this relationship, so the relevant
+     *                   method(s) of Polyobj will also need to be called to
+     *                   complete the job of clearing this relationship.)
      */
     void setPolyobj(Polyobj *newOwner);
 

doomsday/client/include/render/rend_main.h

@@ -88,7 +88,10 @@ void Rend_Shutdown();
 void Rend_Reset();
 void Rend_RenderMap();
 
-void Rend_ModelViewMatrix(boolean use_angles);
+/**
+ * @param useAngles  @c true= Apply viewer angle rotation.
+ */
+void Rend_ModelViewMatrix(bool useAngles = true);
 
 #define Rend_PointDist2D(c) (fabs((vOrigin[VZ]-c[VY])*viewsidex - (vOrigin[VX]-c[VX])*viewsidey))
 
@@ -101,9 +104,9 @@ void Rend_ApplyTorchLight(float *color, float distance);
 
 /**
  * Apply range compression delta to @a lightValue.
- * @param lightValue  Address of the value for adaptation.
+ * @param lightValue  The light level value to apply adaptation to.
  */
-void Rend_ApplyLightAdaptation(float *lightValue);
+void Rend_ApplyLightAdaptation(float &lightValue);
 
 /// Same as Rend_ApplyLightAdaptation except the delta is returned.
 float Rend_LightAdaptationDelta(float lightvalue);
@@ -134,9 +137,12 @@ float Rend_ExtraLightDelta();
  * The offsets in the lightRangeModTables are added to the sector->lightLevel
  * during rendering (both positive and negative).
  */
-void Rend_CalcLightModRange();
+void Rend_UpdateLightModMatrix();
 
-void R_DrawLightRange();
+/**
+ * Draws the lightModRange (for debug)
+ */
+void Rend_DrawLightModMatrix();
 
 /**
  * Sector light color may be affected by the sky light color.

doomsday/client/src/map/p_data.cpp

@@ -199,7 +199,7 @@ DENG_EXTERN_C boolean P_LoadMap(char const *uriCString)
         Cl_InitPlayers();
 
         RL_DeleteLists();
-        Rend_CalcLightModRange();
+        Rend_UpdateLightModMatrix();
 #endif
 
         // Invalidate old cmds and init player values.

doomsday/client/src/map/r_world.cpp

@@ -533,7 +533,7 @@ DENG_EXTERN_C void R_SetupMap(int mode, int flags)
 
 #ifdef __CLIENT__
         // Recalculate the light range mod matrix.
-        Rend_CalcLightModRange();
+        Rend_UpdateLightModMatrix();
 #endif
 
         theMap->initPolyobjs();

doomsday/client/src/network/net_main.cpp

@@ -757,7 +757,7 @@ void Net_Drawer(void)
     Rend_BlockmapDebug();
 
     // Draw the light range debug display.
-    R_DrawLightRange();
+    Rend_DrawLightModMatrix();
 
     // Draw the input device debug display.
     Rend_AllInputDeviceStateVisuals();

doomsday/client/src/render/r_main.cpp

@@ -577,7 +577,7 @@ static void R_UpdateMap()
 
 #ifdef __CLIENT__
     // Recalculate the light range mod matrix.
-    Rend_CalcLightModRange();
+    Rend_UpdateLightModMatrix();
 #endif
 }
 
@@ -1127,7 +1127,10 @@ DENG_EXTERN_C void R_RenderPlayerView(int num)
     // GL is in 3D transformation state only during the frame.
     GL_SwitchTo3DState(true, currentViewport, vd);
 
-    Rend_RenderMap();
+    if(theMap)
+    {
+        Rend_RenderMap();
+    }
 
     // Orthogonal projection to the view window.
     GL_Restore2DState(1, currentViewport, vd);

doomsday/client/src/render/r_shadow.cpp

@@ -301,6 +301,9 @@ void R_InitShadowProjectionListsForMap()
 
 void R_InitShadowProjectionListsForNewFrame()
 {
+    // Disabled?
+    if(!Rend_MobjShadowsEnabled()) return;
+
     // Start reusing nodes from the first one in the list.
     cursorNode = firstNode;
 

doomsday/client/src/render/r_things.cpp

@@ -545,7 +545,7 @@ float R_ShadowStrength(mobj_t *mo)
     else
     {
         ambientLightLevel = mo->bspLeaf->sector().lightLevel();
-        Rend_ApplyLightAdaptation(&ambientLightLevel);
+        Rend_ApplyLightAdaptation(ambientLightLevel);
     }
 
     // Sprites have their own shadow strength factor.
@@ -939,7 +939,7 @@ void getLightingParams(coord_t x, coord_t y, coord_t z, BspLeaf *bspLeaf,
             // Add extra light.
             lightLevel += Rend_ExtraLightDelta();
 
-            Rend_ApplyLightAdaptation(&lightLevel);
+            Rend_ApplyLightAdaptation(lightLevel);
 
             // Determine the final ambientColor in affect.
             for(int i = 0; i < 3; ++i)

doomsday/client/src/render/rend_decor.cpp

@@ -106,7 +106,7 @@ static void projectSource(decorsource_t const &src)
     float max = decor->lightLevels[1];
 
     float lightLevel = src.bspLeaf->sector().lightLevel();
-    Rend_ApplyLightAdaptation(&lightLevel);
+    Rend_ApplyLightAdaptation(lightLevel);
 
     float brightness = checkSectorLightLevel(lightLevel, min, max);
     if(!(brightness > 0)) return;
@@ -200,7 +200,7 @@ static void addLuminousDecoration(decorsource_t &src)
     float max = decor->lightLevels[1];
 
     float lightLevel = src.bspLeaf->sector().lightLevel();
-    Rend_ApplyLightAdaptation(&lightLevel);
+    Rend_ApplyLightAdaptation(lightLevel);
 
     float brightness = checkSectorLightLevel(lightLevel, min, max);
     if(!(brightness > 0)) return;