libgui|GL: Mat4f::lookat() is right-handed by default; cleanup

skyjake · Sep 1, 2019 · fcdadac · fcdadac
1 parent 3e7e308
commit fcdadac
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/doomsday/libs/core/include/de/core/matrix.h b/doomsday/libs/core/include/de/core/matrix.h
@@ -436,7 +436,7 @@ class Matrix4
         return m;
     }
     static Matrix4 lookAt(Vec3 const &target, Vec3 const &eyePos, Vec3 const &up) {
-        return frame(target - eyePos, up) * translate(-eyePos);
+        return frame(target - eyePos, up, true /* right-handed */) * translate(-eyePos);
     }
     static Matrix4 frame(Vec3 const &front, Vec3 const &up, bool mirrored = false) {
         return unnormalizedFrame(front.normalize(), up.normalize(), mirrored);

diff --git a/doomsday/libs/gui/src/graphics/glprogram.cpp b/doomsday/libs/gui/src/graphics/glprogram.cpp
@@ -186,11 +186,11 @@ DENG2_PIMPL(GLProgram)
     {
         DENG2_ASSERT(name != 0);
 
-        LIBGUI_GL.glLinkProgram(name);
+        GL.glLinkProgram(name);
 
         // Was linking successful?
         GLint ok;
-        LIBGUI_GL.glGetProgramiv(name, GL_LINK_STATUS, &ok);
+        GL.glGetProgramiv(name, GL_LINK_STATUS, &ok);
         if (!ok)
         {
             throw LinkerError("GLProgram::link", "Linking failed:\n" + getInfoLog());

diff --git a/doomsday/libs/gui/src/graphics/gltexture.cpp b/doomsday/libs/gui/src/graphics/gltexture.cpp
@@ -309,6 +309,7 @@ void GLTexture::setComparisonMode(gl::ComparisonMode mode, gl::Comparison func)
 {
     d->compareMode = mode;
     d->compareFunc = func;
+    d->flags |= ParamsChanged;
 }
 
 Filter GLTexture::minFilter() const