Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support unsafe_routes on Windows #184

Merged
merged 3 commits into from Feb 26, 2020
Merged

Support unsafe_routes on Windows #184

merged 3 commits into from Feb 26, 2020

Conversation

numkem
Copy link
Contributor

@numkem numkem commented Feb 11, 2020

Tested on Windows 2019 on AWS.

@wadey
Copy link
Member

wadey commented Feb 24, 2020

Thank you, I tested this out and it works great.

Can you update the executable to be the full path:

`C:\Windows\System32\route.exe`

Like we just merged with #191?

@numkem
Copy link
Contributor Author

numkem commented Feb 25, 2020

This should do it!

wadey
wadey approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@wadey wadey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works 👍

@wadey wadey merged commit 4d1928f into slackhq:master Feb 26, 2020
@wadey wadey added this to the v1.2.0 milestone Feb 26, 2020
@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wadey wadey wadey approved these changes

@rawdigits rawdigits Awaiting requested review from rawdigits

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@numkem @wadey @CLAassistant