Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in RecoVertex/TertiaryTracksVertexFinder #38

Closed
slava77 opened this issue May 6, 2014 · 1 comment
Closed

Bug in RecoVertex/TertiaryTracksVertexFinder #38

slava77 opened this issue May 6, 2014 · 1 comment

Comments

@slava77
Copy link
Owner

slava77 commented May 6, 2014

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc481/CMSSW_7_1_CLANG_X_2014-05-05-1600/RecoVertex/TertiaryTracksVertexFinder

apart from:

      RecoVertex/TertiaryTracksVertexFinder/interface/AddTvTrack.h:63:24:

warning: assigning field to itself [-Wself-assign-field]
thePrimaryVertices = thePrimaryVertices; // TYPO ?!?!?!?!?!?!?!
^
RecoVertex/TertiaryTracksVertexFinder/interface/AddTvTrack.h:67:26:
warning: assigning field to itself [-Wself-assign-field]
theSecondaryVertices = theSecondaryVertices; // TYPO ?!?!?!?!?!?

which makes no sense we have also:

    TertiaryTracksVertexFinder/src/GetLineCovMatrix.cc:40:7: warning:

logical not is only applied to the left hand side of this comparison
[-Wlogical-not-parentheses]
if( !fabs(PointTwo.x() - PointOne.x()) < 0.00000001 )

https://hypernews.cern.ch/HyperNews/CMS/get/swReleases/4064.html
@slava77
Copy link
Owner Author

slava77 commented May 15, 2014

addressed in cms-sw#3873
a bigger question is if we need this package at all #41

@slava77 slava77 closed this as completed May 15, 2014
slava77 pushed a commit that referenced this issue May 29, 2014
Merge pull request #38 from dildick/various-additions-to-the-gem-geom…
d37a7f9 
…etry-interface

Various additions to the gem geometry interface
slava77 pushed a commit that referenced this issue Sep 23, 2016
@jbsauvan
Merge pull request #38 from jbsauvan/merge-81x-pr-updates
a14cfba 
81X PR updates
slava77 pushed a commit that referenced this issue Mar 2, 2017
@roger-wolf
Merge pull request #38 from mbluj/fixes_for_90X
f763936 
Fixes for 90X
slava77 pushed a commit that referenced this issue Nov 16, 2017
@gpetruc
Merge pull request #38 from olaiya/cms-nanoAOD/master_moreElectronVars
ce615a5 
Added non-PF track, ecal and hcal isolation within a cone of 0.3
slava77 pushed a commit that referenced this issue Jul 1, 2019
@fwyzard
Merge pull request #38 from makortel/cudaService_salvatore
a9b33b6 
Updates to CUDAService from Salvatore
slava77 pushed a commit that referenced this issue Mar 9, 2021
@djcranshaw @skinnari
Updated ME and PR loop factors to match HLS (#38)
17a6755
slava77 pushed a commit that referenced this issue Sep 3, 2021
@osschar
Merge pull request #38 from trackreco/updateJsonsPR340
a287e1a 
Update json files according to PR 340 + PR 344
slava77 pushed a commit that referenced this issue Oct 9, 2021
@cerati
Merge pull request #38 from cerati/mt-devel
623a3d9 
Add commandline parametrs for nEvents and nTracks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slava77