Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another round of clang RecoVertex warnings / errors fixes #3873

Merged
merged 14 commits into from May 15, 2014

Conversation

ktf
Copy link
Contributor

@ktf ktf commented May 14, 2014

This is a rebase of @thspeer #3869 which included changes from DataFormats/Math which were not intended (yet) for the base CMSSW_7_1_X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_1_X.

Another round of clang RecoVertex warnings / errors fixes

It involves the following packages:

RecoVertex/AdaptiveVertexFit
RecoVertex/BeamSpotProducer
RecoVertex/GhostTrackFitter
RecoVertex/KinematicFitPrimitives
RecoVertex/LinearizationPointFinders
RecoVertex/MultiVertexFit
RecoVertex/PrimaryVertexProducer
RecoVertex/TertiaryTracksVertexFinder
RecoVertex/TrimmedKalmanVertexFinder
RecoVertex/V0Producer

@nclopezo, @cmsbuild, @anton-a, @diguida, @rcastello, @slava77, @Degano, @thspeer can you please review it and eventually sign? Thanks.
@ferencek, @cerati, @GiacomoSguazzoni, @pvmulder, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented May 14, 2014

is RecoVertex/TertiaryTracksVertexFinder actually used anywhere by anyone?

@VinInn
Copy link
Contributor

VinInn commented May 15, 2014

Very good question!
If used, it needs a major "refurbishing"

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented May 15, 2014

+1

for d6314f1
based on jenkins.

The only place where there was an actual bug fix is not used in reco (and probably by nobody else either)

@davidlange6
Copy link
Contributor

nothing here should be under alca.. so bypassing

davidlange6 added a commit that referenced this pull request May 15, 2014
Another round of clang RecoVertex warnings / errors fixes
@davidlange6 davidlange6 merged commit 66fa3a3 into cms-sw:CMSSW_7_1_X May 15, 2014
@ktf ktf deleted the clang-recovertex-warnings branch June 16, 2014 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants