io.encodings: fix for read-until seps not containing \n.

slavapestov · Oct 31, 2014 · 5961cfb · 5961cfb
1 parent 632ee27
commit 5961cfb
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 5 deletions.
diff --git a/core/io/encodings/encodings-tests.factor b/core/io/encodings/encodings-tests.factor
@@ -87,3 +87,15 @@ unit-test
         "\r\n" read-until
     ] with-byte-reader
 ] unit-test
+
+{
+    "! lol"
+    "! wa"
+    116
+} [
+    "! lol\r\n! wat\r\n" utf8 encode
+    utf8 [
+        readln
+        "t" read-until
+    ] with-byte-reader
+] unit-test
diff --git a/core/io/encodings/encodings.factor b/core/io/encodings/encodings.factor
@@ -163,13 +163,18 @@ M: decoder stream-contents*
 
 M: decoder stream-read-until
     dup cr>> [
-        2dup
+        dup cr- 2dup
         >decoder< decode-until
-        2dup [ empty? ] [ CHAR: \n = ] bi* and [
-            2drop stream-read-until
+        over [
+            dup CHAR: \n = [
+                2drop stream-read-until
+            ] [
+                [ 2drop ] 2dip
+            ] if
         ] [
-            [ cr- drop ] 2dip
-        ] if
+            first-unsafe CHAR: \n = [ [ rest ] dip ] when
+            [ 2drop ] 2dip
+        ] if-empty
     ] [
         >decoder< decode-until
     ] if ;