Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Commit

Permalink
Correct http return code of identify versions api
Browse files Browse the repository at this point in the history
Keystone returns 300 http code (Multiple Choices) instead of 200 (OK)
[0] when client GETs the api version info that current identify service
supported.

This wrong return code causes keystonemiddleware failed at api version
query [1] with error "Unable to get version info from keystone: 200",
which middleware as a client of keystone lives in a upperlayer service.

[0]
https://github.com/openstack/keystone/blob/master/keystone/controllers.py#L132
[1]
https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token.py#L1245

For the details of curl test, see
http://paste.openstack.org/show/92177/ .

Signed-off-by: Zhi Yan Liu <zhiyanl@cn.ibm.com>
  • Loading branch information
Zhi Yan Liu committed Aug 8, 2014
1 parent 0c12f4b commit 1b7d01b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions jumpgate/identity/drivers/sl/versions.py
@@ -1,10 +1,12 @@
import falcon


class Versions(object):
def __init__(self, disp):
self.disp = disp

def on_get(self, req, resp):
resp.status = falcon.HTTP_300
resp.body = {
'versions': {
'values': [
Expand Down

0 comments on commit 1b7d01b

Please sign in to comment.