Allow key interpolation of Text ToJSONKey types
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for `Text` keys, which were previously rejected for not being Strings which could be packed into Text - a weird behaviour. Only direct-to-Text-style JSON keys are supported at the moment, as array-style keys are more complex to encode, and would require a change to the code-generation logic.
ivanbakel
changed the title
ToJSONKey typeToJSONKey types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A QoL improvement I had a need for this morning.
This allows for
Textkeys, which were previously rejected for not being Strings which could be packed into Text. I haven't added encoding the array-style keys, since that would have required modifying larger parts of the codegen logic.