Remove node-fetch #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node-fetch is stale, causes problems in downstream libraries, and is now replaceable with the better native fetch function in node.js. I wasn't able to build solid-auth-fetcher, but I think you'll find that commenting it out gives you a better fetch. If you have to import something, try cross-fetch which is at least updated. BTW I still use solid-auth-fetcher in solid-shell which has at least one user (he copies his timbl.com to his desktop with it).
This was referenced Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node-fetch is stale, causes problems in downstream libraries, and is now replaceable with the better and more recently updated cross-fetch. I wasn't able to build solid-auth-fetcher, but substituting cross-fetch for node-fetch directy in the obtainAuthHeaders.js eliminated the downstream errors (in solid-node-client and solid-shell).