-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not initialize promotions object on startup #5728
Merged
kennyadsl
merged 1 commit into
solidusio:main
from
mamhoff:do-not-initialize-promotions-object-on-startup
May 6, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
# frozen_string_literal: true | ||
|
||
require "spec_helper" | ||
|
||
RSpec.describe Spree::ApiConfiguration do | ||
subject(:config) { Spree::ApiConfiguration.new } | ||
|
||
describe "#promotion_attributes" do | ||
subject(:promotion_attributes) { config.promotion_attributes } | ||
|
||
it { is_expected.to eq(Spree::Config.promotions.promotion_api_attributes) } | ||
|
||
it "can be changed" do | ||
config.promotion_attributes << :foo | ||
expect(promotion_attributes).to include(:foo) | ||
end | ||
|
||
it "can delete attributes" do | ||
expect(promotion_attributes).to include(:name) | ||
config.promotion_attributes.delete(:name) | ||
expect(promotion_attributes).not_to include(:name) | ||
end | ||
end | ||
|
||
describe "#promotion_attributes=" do | ||
subject(:promotion_attributes_setter) { config.promotion_attributes = [:name] } | ||
|
||
around do |example| | ||
original_attributes = Spree::Config.promotions.promotion_api_attributes | ||
Spree.deprecator.silence do | ||
example.run | ||
end | ||
Spree::Config.promotions.promotion_api_attributes = original_attributes | ||
end | ||
|
||
it "sets the promotion_attributes" do | ||
promotion_attributes_setter | ||
expect(config.promotion_attributes).to eq([:name]) | ||
end | ||
end | ||
end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this also supports pushing new attributes to the array.
And also removing items from the array. Shouldn't we also support those kind of customizations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these are still possible, as the list of attributes is just an array of symbols at the end. I've added some specs to prove it.