Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to use notarytool #1408

Merged
merged 1 commit into from Apr 17, 2024
Merged

Try to use notarytool #1408

merged 1 commit into from Apr 17, 2024

Conversation

vespakoen
Copy link
Contributor

Untested...

Should be fixing #1407

@phkahler
Copy link
Member

@rpavlik can you have a look?

@phkahler phkahler linked an issue Sep 23, 2023 that may be closed by this pull request
@phkahler
Copy link
Member

@vespakoen It passes all the test, so just merge it and see what happens ;-) We should get an edge build without warnings right?

@rpavlik
Copy link
Contributor

rpavlik commented Sep 26, 2023

Sorry, I have no modern mac experience since 10.6. but hey, if it passes, I am in favor of merge if it seems needed.

@vespakoen
Copy link
Contributor Author

The tests don't run the notarytool thing, only the CD workflow does that.
I was going to merge this once I have some time on my hands so I can correct any problems if they should occur ;)

@phkahler
Copy link
Member

The tests don't run the notarytool thing, only the CD workflow does that.

@vespakoen and @ruevs and @rpavlik What do you think about getting a 3.2rc1 our soon? And wrapping up 3.2 before year end?

@ruevs
Copy link
Member

ruevs commented Sep 27, 2023

It is a great idea. There is enough - especially in "SolveSpace scale" - for a new release. But I really, really want to fix these https://github.com/solvespace/solvespace/milestone/5 before a final 3.2. I've self assigned most of them but they are the typical "boring" stuff that I never feel like starting...

@phkahler
Copy link
Member

But I really, really want to fix these

Three of those are path issues with linked parts!

I have at least one tweak I want to make too. Solvespace turned 10 this year as open source.

@ruevs
Copy link
Member

ruevs commented Sep 29, 2023

Solvespace turned 10 this year as open source.

And 15 as a program - the first commit 6713923 Tuesday 2008-03-25 02:02:13 -0800. And 16 if we count when @jwesthues released SketchFlat (Oct 2007, Cambridge MA).

https://en.wikipedia.org/wiki/She_Walks_in_Beauty

@phkahler
Copy link
Member

@vespakoen can I nudge you to get this and any other mac stuff in order? ;-)

@vespakoen
Copy link
Contributor Author

I'll try to look into this after the weekend

@ruevs
Copy link
Member

ruevs commented Apr 17, 2024

@vespakoen @phkahler the CI now fails on macOS entirely https://github.com/solvespace/solvespace/actions/runs/8725534390
I'll merge this - let's see if it works.

++ xcrun altool --notarization-info '' -u *** -p ***
+ progress='2024-04-17 16:56:15.551 *** Error: Failed to get notarization info.
2024-04-17 16:56:15.551 *** Error: Notarization of MacOS applications using altool has been decommissioned. Please use notarytool. See: https://developer.apple.com/documentation/technotes/tn3147-migrating-to-the-latest-notarization-tool (-1031)'
Error: Process completed with exit code 1.

@ruevs ruevs merged commit a17ee17 into master Apr 17, 2024
8 checks passed
@ruevs
Copy link
Member

ruevs commented Apr 17, 2024

@vespakoen Naaah it did not work. And the build time became 24m55s (from 12m1s before) - it builds everything twice ;-(
https://github.com/solvespace/solvespace/actions/runs/8727893435/job/23946718599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI, macOS: update action to use "notarytool" instead of "altool"
4 participants