Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

Commit

Permalink
Fixing the build.
Browse files Browse the repository at this point in the history
forge parent 27 introduced this change:
sonatype/oss-parents@9261d09

But it breaks Nexus build for following reason:
modules nexus-plugin-api and nexus-plugin-test-api are
"grouping" POMs (provided all is needed for plugin dev and
plugin testing) but themselves does not have any content yet.

Adding content was once discussed (moving in plugin-api and plugin-host-api etc)
but did not happen.

So, what happens, is that reactor build will not have main JAR artifact
for these (as they are empty and parent pom instructs JAR plugin to not
create empty JARs), but all the plugins are referencing these modules
as JARs. In case of CLI build using "-U" you will see that the JAR
is checked/fetched from remote. Zion on the other hand, simply
fails, as it is isolated environment, and will not have the JAR
accessible by any means.
  • Loading branch information
cstamas committed Dec 5, 2012
1 parent f3e262c commit 06909c4
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions pom.xml
Expand Up @@ -1207,6 +1207,14 @@
<pluginManagement>
<plugins>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<skipIfEmpty>false</skipIfEmpty>
</configuration>
</plugin>

<plugin>
<groupId>org.jboss.tattletale</groupId>
<artifactId>tattletale-maven</artifactId>
Expand Down

2 comments on commit 06909c4

@jdillon
Copy link
Contributor

@jdillon jdillon commented on 06909c4 Dec 5, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should have been done in the 2 places where its needed (with comments to explain what its for/why its there), as this generally isn't needed... though I do understand why its needed for the 2 grouping modules.

@peterlynch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree - it also should have been done correctly in first place by me ;). In my haste I forgot why I was delaying using forge-parent greater than version 24 - because 25+ has skipIfEmpty=true

Please sign in to comment.