[dash]: Add DPU kvm topology guidance #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ze Gan <ganze718@gmail.com>
qiluo-msft
reviewed
Apr 27, 2024
|
|
||
| ``` | ||
| # /root/update1 and /root/update2 are protobuf value for DASH table | ||
| python2 /root/gnxi/gnmi_cli_py/py_gnmicli.py --timeout 30 -t 10.0.0.88 -p 50052 -xo sonic-db -rcert /root/gnmiCA.pem -pkey /root/gnmiclient.key -cchain /root/gnmiclient.crt -m set-update --xpath /APPL_DB/localhost/DASH_APPLIANCE_TABLE[key=123] /APPL_DB/localhost/DASH_VNET_TABLE[key=Vnet1] --value $/root/update1 $/root/update2 |
There was a problem hiding this comment.
py_gnmicli.py is using python2, need to rewrite this tool.
qiluo-msft
reviewed
Apr 27, 2024
| Once dash test cases are completed, we can find required certificates in sonic-mgmt container. | ||
|
|
||
| ``` | ||
| # The certificates are in /tmp directory |
There was a problem hiding this comment.
Now we generate new certificate for dash test, if there's any requirement, we can use fixed certificate.
There was a problem hiding this comment.
Let's be frank and warn the reader if it has possibility to happen. Another option is to use fixed certificate.
There was a problem hiding this comment.
Feel free to use another PR to resolve this comment.
r12f
approved these changes
Apr 27, 2024
qiluo-msft
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.