Stop relying on !slots, SPOT lexicals into Decl

sorear · Jul 21, 2010 · 3963e68 · 3963e68
1 parent 03f7ce1
commit 3963e68
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 15 deletions.
diff --git a/Body.pm b/Body.pm
@@ -12,7 +12,6 @@ use CgOp ();
     has do        => (isa => 'Op', is => 'rw');
     has enter     => (isa => 'ArrayRef[Op]', is => 'ro',
         default => sub { [] });
-    has lexical   => (isa => 'HashRef', is => 'ro', default => sub { +{} });
     has outer     => (isa => 'Body', is => 'rw', init_arg => undef);
     has decls     => (isa => 'ArrayRef', is => 'ro', default => sub { [] });
     has code      => (isa => 'CodeGen', is => 'ro', init_arg => undef,
@@ -24,6 +23,12 @@ use CgOp ();
     # also '' for incorrectly contextualized {p,x,}block, blast
     has type      => (isa => 'Str', is => 'rw');
 
+    sub lexical {
+        my ($self) = @_;
+
+        +{ map { $_, 1 } map { $_->used_slots } @{ $self->decls } };
+    }
+
     sub is_mainline {
         my $self = shift;
 

diff --git a/CodeGen.pm b/CodeGen.pm
@@ -280,10 +280,6 @@ use 5.010;
     sub lextypes {
         my ($self, %args) = @_;
         #say STDERR "lextypes: @args";
-        my $body = $self->body // $self->bodies->[-1];
-        if ($body) {
-            for (keys %args) { $body->lexical->{$_} = 1 }
-        }
         %{ $self->lex2type } = (%{ $self->lex2type }, %args);
     }
 
@@ -552,9 +548,11 @@ use 5.010;
         my ($self, $name, $set) = @_;
         my $body = $self->body // $self->bodies->[-1];
         my ($order, $scope) = (0, $body);
-        while ($scope && !$scope->lexical->{$name}) {
-            $scope = $scope->outer;
-            $order++;
+        if (! $self->lex2type->{$name}) {
+            while ($scope && !$scope->lexical->{$name}) {
+                $scope = $scope->outer;
+                $order++;
+            }
         }
         if (!$scope) {
             die "Failed to resolve lexical $name in " . $body->name;

diff --git a/Niecza/Actions.pm b/Niecza/Actions.pm
@@ -1056,11 +1056,6 @@ sub statevar { my ($cl, %ex) = @_;
 }
 
 sub blockcheck { my ($cl) = @_;
-    for my $d (@{ $::CURLEX->{'!decls'} // [] }) {
-        for my $sl ($d->used_slots) {
-            $::CURLEX->{'!slots'}{$sl} = 1;
-        }
-    }
 }
 
 sub sl_to_block { my ($cl, $type, $ast, %args) = @_;
@@ -1077,8 +1072,7 @@ sub sl_to_block { my ($cl, $type, $ast, %args) = @_;
         type      => $type,
         $args{bare} ? () : (
             decls   => ($::CURLEX->{'!decls'} // []),
-            enter   => ($::CURLEX->{'!enter'} // []),
-            lexical => ($::CURLEX->{'!slots'} // {})),
+            enter   => ($::CURLEX->{'!enter'} // [])),
         signature => $args{signature},
         do        => $ast);
 }