Fix unquoted environment variable in check_os.sh #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my RHEL system, ID is initially set to 'ID_LIKE="RHEL CENTOS FEDORA"', which, when expanded in the if-statement, turns into this: if [ -z ID_LIKE=RHEL CENTOS FEDORA ]; then and causes the error: `souffle/sh/check_os.sh: line 15: [: too many arguments` It is necessary to quote $ID
strRM
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2469 +/- ##
==========================================
+ Coverage 78.19% 78.24% +0.05%
==========================================
Files 486 486
Lines 32423 32423
==========================================
+ Hits 25352 25369 +17
+ Misses 7071 7054 -17 |
quentin
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake failed to setup the build properly, because the environment variable ID was tested in check_os.sh without quoting it. This led to the error
souffle/sh/check_os.sh: line 15: [: too many arguments. In my case, that variable was toID_LIKE="RHEL CENTOS FEDORA", which expands to multiple words when done without quoting.