Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use all-in-one ms_dotnet cookbook #61

Merged
merged 6 commits into from Dec 11, 2015
Merged

Use all-in-one ms_dotnet cookbook #61

merged 6 commits into from Dec 11, 2015

Commits on Nov 30, 2015

  1. Use all-in-one ms_dotnet cookbook 

    ms_dotnet is a 'all-in-one' cookbook allowing you to configure almost
all .NET versions; It has been written following the same model as this
powershell cookbook and is actively maintained by @criteo.

Reason for this migration:
* Having a single dependency to setup .NET is better than multiple ones.
* ms_dotnet is more up-to-date than others cookbooks
* ms_dotnet is going to support .NET 4.6 soon
* ms_dotnet is rspec testable on linux using ohais instead of Win32 API

Other changes:
* Because a single recipe takes care of .NET 4 & 4.5, if attributes
are not set properly powershell4 recipe which require .NET 4.5 will
throw an exception.
Some lines of code reimplementing .NET activation have been removed.
    @Annih
    Annih committed Nov 30, 2015
    Configuration menu
    Copy the full SHA
    79ae729 View commit details
    Browse the repository at this point in the history

  2. Fix rubocop violations 

    * Ignore foodcritic rule sous-chefs#9 for windows package success_codes
* Refactor winrm recipe's if statements to remove one nested block
* Fix `NoMethodError: undefined method `empty' for nil:NilClass`
when powershell.winrm.thumbprint is nil
    @Annih
    Annih committed Nov 30, 2015
    Configuration menu
    Copy the full SHA
    c4db2d6 View commit details
    Browse the repository at this point in the history

  3. Fix specs for powershell recipes 

    * Update powershell's recipes' specs to test the new code.
* Removed useless tests - e.g. windows 7 Core does not exist.
* Tests factorization to avoid code/mistake duplication.
    @Annih
    Annih committed Nov 30, 2015
    Configuration menu
    Copy the full SHA
    2e9ecc8 View commit details
    Browse the repository at this point in the history

  4. Fix specs for winrm recipe 

    Update winrm's specs to be able to test on linux/travis:
* Remove references to `chef/winr32/version`
* Mock shellout commands
    @Annih
    Annih committed Nov 30, 2015
    Configuration menu
    Copy the full SHA
    a7d14e2 View commit details
    Browse the repository at this point in the history

  5. Fix specs for dsc recipe 

    Update dsc's specs to comply with powershell::powershell4 changes.
Mock properly shellout commands.
    @Annih
    Annih committed Nov 30, 2015
    Configuration menu
    Copy the full SHA
    2d48a00 View commit details
    Browse the repository at this point in the history

  6. Fix specs for powershell_module provider 

    Clean up powershell_module provider specs:
* Mock file system operations and remove all actual IO from the tests!
* Remove use of environment variable

Theses tests were relying on the test machine file system:
 * It was expecting the test machine to be windows with powershell etc.
 * It was also creating "temporary" files and folders.
    @Annih
    Annih committed Nov 30, 2015
    Configuration menu
    Copy the full SHA
    7927717 View commit details
    Browse the repository at this point in the history