Trim down v2alpha1.ActivationV1 #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
approved these changes
Apr 16, 2024
|
For me OK, but maybe @kacpersaw should also take a look at the change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to trim down the ATX domain type in the node to contain only the necessary fields. We will remove fields needed only for new ATX verification like POST and sequence number. Additionally, the ATX weight will be calculated differently with the ATX merge (weight will be the sum of merged identities). Hence replaced
base_tick_height,tick_count, andnum_unitswithweightandheight.@kacpersaw are any of the removed fields needed in the explorer?