New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support poet certificates #5221
Open
poszu
wants to merge
63
commits into
develop
Choose a base branch
from
support-poet-certificates
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poszu
force-pushed
the
support-poet-certificates
branch
from
November 3, 2023 16:20
af7311b
to
2540b1e
Compare
bors try |
tryBuild failed: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5221 +/- ##
=========================================
- Coverage 80.5% 80.5% -0.1%
=========================================
Files 286 288 +2
Lines 29547 29878 +331
=========================================
+ Hits 23812 24063 +251
- Misses 4137 4185 +48
- Partials 1598 1630 +32 ☔ View full report in Codecov by Sentry. |
bors try |
poszu
force-pushed
the
support-poet-certificates
branch
from
November 9, 2023 07:01
7c1cd15
to
f1f44be
Compare
poszu
force-pushed
the
support-poet-certificates
branch
from
November 10, 2023 05:21
acd63d6
to
a2893dc
Compare
bors try |
poszu
force-pushed
the
support-poet-certificates
branch
from
November 10, 2023 08:19
c19d390
to
ffd77d0
Compare
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
fasmat
requested changes
Apr 17, 2024
fasmat
reviewed
Apr 17, 2024
fasmat
reviewed
Apr 17, 2024
fasmat
reviewed
Apr 17, 2024
fasmat
reviewed
Apr 17, 2024
fasmat
reviewed
Apr 18, 2024
fasmat
reviewed
Apr 18, 2024
bors try |
tryBuild succeeded: |
fasmat
reviewed
Apr 18, 2024
bors try |
tryBuild succeeded: |
fasmat
reviewed
Apr 24, 2024
fasmat
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #5204
Changes
Added support for registering in the poet services using a certificate instead of PoW. It still supports both ways and will fallback to the PoW if:
There is a new interface in
activation
packagecertifierService
that provides a generic way to obtain a certificate for a given poet. It abstracts away the fact that a POST proof is used - it is hidden incertifierServiceClient
, which could in future have different implementations for other poet services.Changed the
initial_post
table topost
as it now holds the latest POST proof. Relying solely on initial post proof OR an existing ATX could not work in case of a checkpoint (in fact this way it failed systests).Test Plan