New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Listen for \q to gracefully shutdown the node #5389
base: develop
Are you sure you want to change the base?
Listen for \q to gracefully shutdown the node #5389
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #5389 +/- ##
==========================================
+ Coverage 0 77.6% +77.6%
==========================================
Files 0 266 +266
Lines 0 30906 +30906
==========================================
+ Hits 0 24003 +24003
- Misses 0 5389 +5389
- Partials 0 1514 +1514 ☔ View full report in Codecov by Sentry. |
Inconsistent behavior when Node is compacting the database and receives
Except for this inconsistent behavior — LGTM. |
I don't think listening to stdin is necessary to make a graceful shutdown on windows work. Instead we should try adding See also this change for it: https://go-review.googlesource.com/c/go/+/187739 EDIT: my bad - the problem is not the receiving program in windows its the sender. A assume |
bors merge |
## Motivation Issue #5321 Listening for \q will allow smapp to gracefully shutdown the node. Co-authored-by: Matthias <5011972+fasmat@users.noreply.github.com>
Build failed: |
The merge failed because reading from |
Motivation
Issue #5321
Listening for \q will allow smapp to gracefully shutdown the node.