[Merged by Bors] - p2p: use backoff during routing discovery #5882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid excess DHT queries and connection attempts
ivan4th
force-pushed
the
feature/slower-disc
branch
from
cf0e9da
to
be708d8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5882 +/- ##
=======================================
Coverage 80.6% 80.6%
=======================================
Files 285 285
Lines 29521 29568 +47
=======================================
+ Hits 23805 23849 +44
- Misses 4125 4127 +2
- Partials 1591 1592 +1 ☔ View full report in Codecov by Sentry. |
fasmat
reviewed
Apr 25, 2024
poszu
reviewed
Apr 29, 2024
Co-authored-by: Bartosz Różański <bartek.roza@gmail.com>
Co-authored-by: Bartosz Różański <bartek.roza@gmail.com>
There was no error checking for DHT discovery startup, yet it could fail e.g. during LevelDB corruption: ``` Error: init services: error starting discovery: open leveldb at /opt/go-spacemesh/go-spacemesh-0/p2p: leveldb/journal: block/chunk corrupted: chunk length overflows block (1270 bytes) [file=000247.log] ``` In this case, error was being swallowed and DHT not started, breaking acquisition of new peers. Co-authored-by: Ivan Shvedunov <ivan4th@users.noreply.github.com>
fasmat
approved these changes
Apr 29, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
## Motivation Previous attempts at enabling routing discovery caused network overload on some of the nodes Co-authored-by: Ivan Shvedunov <ivan4th@users.noreply.github.com>
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previous attempts at enabling routing discovery caused network overload on some of the nodes
Description
Avoid excess DHT queries and connection attempts by using the same backoff mechanisms as those used by Kubo and peer discovery code in
go-libp2p-pubsubTest Plan
Tested on a mainnet node
TODO