New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option for zip downloads #1299
add option for zip downloads #1299
Conversation
for more information, see https://pre-commit.ci
…-gallery into jamiecook/zip_downloads
If this is a common enough use case -- that people's internet is restricted -- we should probably make all projects that use SG expose a So perhaps rather than a separate config option we could add a third download "entry" for all projects that use SG:
That way people who can download directly still can, and people who have more restricted access can get what they need. I understand this is slightly less flexible in that people who have restricted access have to "download both" in all cases, but I think it's an acceptable tradeoff for those folks to have to (very easily!) delete the one small extra file they get once extracting, or more carefully just extract the one file that they want. The And if there are projects that hate this new |
Thats a good idea - I will modify and resubmit |
@larsoner that is done, much smaller delta on this one now |
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
I think this one just needs approval to run all the other CI workflows. |
Thanks @jamiecook ! |
Our IT department prevents downloads of .py and .ipynb files.
This PR adds an option (documented) that allows for generating .py.zip and .ipynb.zip files instead.