Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try at parallel gallery generation #877

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jschueller
Copy link
Contributor

@jschueller jschueller commented Oct 28, 2021

A naive attempt at #25:

  • Does not work
  • Only attempts to parallelize generation one directory at a time
  • Hard-wired number of processes
  • It's something

@larsoner
Copy link
Contributor

Thinking about this a bit more, I'd expect this not to work for (at least) the matplotlib, mayavi, and pyvista scrapers because these are all global-state based. And then there will be tricky interactions with reset_modules, which also by default does global state stuff at least for matplotlib. So I'm not sure this will ever work at least for the majority of our users :(

@larsoner
Copy link
Contributor

I'll copy that over to the issue so more people can tell me how I'm wrong :)

@jschueller
Copy link
Contributor Author

maybe the sphinx folks (@samdoran or @tk0miya) could give hints, or sklearn (@Titan-C @GaelVaroquaux) would be interested in speeding up their builds too ?

@tk0miya
Copy link

tk0miya commented Jan 11, 2022

It seems this handler is invoked on the bootstrap process of Sphinx (on builder-inited event). So there is no special support from Sphinx framework.

@jschueller
Copy link
Contributor Author

indeed, we're looking at parallelizing the gallery jobs at the extension level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants