forked from prusa3d/PrusaSlicer
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base type interfaces for soluble interface supports #2
Open
spiky2021
wants to merge
24
commits into
master
Choose a base branch
from
sp_base_interfaces
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment soluble support material adhesion is weak due to sparse support layers under soluble support layers. I reported as issue prusa3d#5823 with pictures, as well. I modified two methods to the SupportMaterial Class including their headers. The new methods add two base type interface layers to the support structure, in case the extruders are different and soluble support is choosen. Since it is conditionally activated, it in general doesn't need a GUI input. But a GUI option number of base interface layers may enabled users to adapt this feature to their needs. This is my second try to provide a pull request on this topic. Reset my fromer repository, because first I merged this and all other changes to my master and couldn't provide separate pull request anymore.
Artillery Sidewinder X1 Artillery Genius prusa3d/PrusaSlicer-settings#122
creality.ini: add Ender-3 Max
similar instance: prusa3d@08388d3 related to: prusa3d#5752
the line `brew install cmake git gettext` wasn't visible due to formatting error
when open/close Preferences
under soluble supports. prusa3d#5823 Implemented as a pull request prusa3d#5903 by @spiky2021 and reworked. commit c7993e6 Author: spiky2021 <77010315+spiky2021@users.noreply.github.com> Date: Thu Feb 11 12:39:25 2021 +0100 Base type interfaces for soluble interface supports At the moment soluble support material adhesion is weak due to sparse support layers under soluble support layers. I reported as issue prusa3d#5823 with pictures, as well. I modified two methods to the SupportMaterial Class including their headers. The new methods add two base type interface layers to the support structure, in case the extruders are different and soluble support is choosen. Since it is conditionally activated, it in general doesn't need a GUI input. But a GUI option number of base interface layers may enabled users to adapt this feature to their needs. This is my second try to provide a pull request on this topic. Reset my fromer repository, because first I merged this and all other changes to my master and couldn't provide separate pull request anymore.
…lider in preview
Processing of CoolingBuffer is newly staggered for support layers until the 1st object layer above supports is received by CoolingBuffer.
+ Try to fix accidentally crash on Copy/Paste
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment soluble support material adhesion is weak due to sparse support layers under soluble support layers. I reported as issue prusa3d#5823 with pictures, as well.
I modified two methods to the SupportMaterial Class including their headers.
The new methods add two base type interface layers to the support structure, in case the extruders are different and soluble support is choosen.
Since it is conditionally activated, it in general doesn't need a GUI input. But a GUI option number of base interface layers may enabled users to adapt this feature to their needs.
This is my second try to provide a pull request on this topic. Reset my fromer repository, because first I merged this and all other changes to my master and couldn't provide separate pull request anymore.