New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration metadata for feign.autoconfiguration.jackson.enabled #478
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.2.x #478 +/- ##
============================================
- Coverage 79.79% 76.92% -2.87%
- Complexity 428 436 +8
============================================
Files 57 54 -3
Lines 1653 1634 -19
Branches 232 242 +10
============================================
- Hits 1319 1257 -62
- Misses 238 256 +18
- Partials 96 121 +25
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KENNYSOFT Thanks for submitting the PR. The change looks good to me, however, it would make sense to add it to the Hoxton release train as well. Could you submit these changes against 2.2.x instead of master? I will merge it straight away then.
Ok I should rebase this branch. Please wait! |
@KENNYSOFT it might be easier to create a new branch based on |
d838ed6
to
e562068
Compare
Yup just cherry-picked 😁 |
Have no idea why CI fails and Codecov report did not update... maybe I should not force-push my branch 😭 |
Don't worry about it. There seems to be an issue with our CircleCI build. It fails here, but passes locally and on Jenkins. Will have to fix it. |
#430 haven't added configuration metadata for
feign.autoconfiguration.jackson.enabled
, so I added it.I've seen #470, so
defaultValue
can be changed by next major release.