Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration metadata for feign.autoconfiguration.jackson.enabled #478

Merged
merged 1 commit into from Feb 8, 2021

Conversation

KENNYSOFT
Copy link
Contributor

image

#430 haven't added configuration metadata for feign.autoconfiguration.jackson.enabled, so I added it.

I've seen #470, so defaultValue can be changed by next major release.

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #478 (d838ed6) into 2.2.x (63ba4d4) will decrease coverage by 2.86%.
The diff coverage is 72.96%.

Impacted file tree graph

@@             Coverage Diff              @@
##              2.2.x     #478      +/-   ##
============================================
- Coverage     79.79%   76.92%   -2.87%     
- Complexity      428      436       +8     
============================================
  Files            57       54       -3     
  Lines          1653     1634      -19     
  Branches        232      242      +10     
============================================
- Hits           1319     1257      -62     
- Misses          238      256      +18     
- Partials         96      121      +25     
Impacted Files Coverage Δ Complexity Δ
...ringframework/cloud/openfeign/DefaultTargeter.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...work/cloud/openfeign/FeignClientSpecification.java 28.57% <0.00%> (+2.48%) 3.00 <0.00> (ø)
...ign/annotation/PathVariableParameterProcessor.java 42.85% <0.00%> (+1.94%) 4.00 <0.00> (ø)
...enfeign/annotation/QueryMapParameterProcessor.java 88.88% <ø> (ø) 4.00 <0.00> (ø)
...oud/openfeign/encoding/BaseRequestInterceptor.java 87.50% <ø> (ø) 3.00 <0.00> (ø)
...ding/FeignAcceptGzipEncodingAutoConfiguration.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
.../encoding/FeignContentGzipEncodingInterceptor.java 43.47% <0.00%> (+1.81%) 8.00 <0.00> (ø)
...adbalancer/FeignLoadBalancerAutoConfiguration.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...ork/cloud/openfeign/support/PageJacksonModule.java 59.25% <ø> (ø) 4.00 <0.00> (ø)
...cloud/openfeign/support/PageableSpringEncoder.java 78.57% <0.00%> (+1.82%) 14.00 <0.00> (ø)
... and 49 more

Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KENNYSOFT Thanks for submitting the PR. The change looks good to me, however, it would make sense to add it to the Hoxton release train as well. Could you submit these changes against 2.2.x instead of master? I will merge it straight away then.

@OlgaMaciaszek OlgaMaciaszek added this to In progress in Hoxton.SR10 via automation Feb 8, 2021
@OlgaMaciaszek OlgaMaciaszek added this to In progress in 2020.0.2 via automation Feb 8, 2021
@OlgaMaciaszek OlgaMaciaszek added this to the 2.2.7.RELEASE milestone Feb 8, 2021
@KENNYSOFT KENNYSOFT changed the base branch from master to 2.2.x February 8, 2021 15:23
@KENNYSOFT
Copy link
Contributor Author

Ok I should rebase this branch. Please wait!

@KENNYSOFT KENNYSOFT marked this pull request as draft February 8, 2021 15:24
@OlgaMaciaszek
Copy link
Collaborator

@KENNYSOFT it might be easier to create a new branch based on 2.2.x and cherry-pick this (or even copy, since it's a small change).

@KENNYSOFT
Copy link
Contributor Author

Yup just cherry-picked 😁

@KENNYSOFT KENNYSOFT marked this pull request as ready for review February 8, 2021 15:29
@KENNYSOFT
Copy link
Contributor Author

KENNYSOFT commented Feb 8, 2021

Have no idea why CI fails and Codecov report did not update... maybe I should not force-push my branch 😭

@OlgaMaciaszek
Copy link
Collaborator

Don't worry about it. There seems to be an issue with our CircleCI build. It fails here, but passes locally and on Jenkins. Will have to fix it.

@OlgaMaciaszek OlgaMaciaszek merged commit cc9af41 into spring-cloud:2.2.x Feb 8, 2021
Hoxton.SR10 automation moved this from In progress to Done Feb 8, 2021
2020.0.2 automation moved this from In progress to Done Feb 8, 2021
@KENNYSOFT KENNYSOFT deleted the metadata-jackson branch February 8, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
2020.0.2
  
Done
Hoxton.SR10
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants