Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n + Features #719

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

aewinformatica
Copy link

  • FIX Maven Project Build Lifecycle Mapping Problem
  • update Owner list from better view Pets List
  • messages - Include pt_BR
  • Date Internationalization

@pivotal-issuemaster
Copy link

@aewinformatica Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@aewinformatica Thank you for signing the Contributor License Agreement!

@dsyer
Copy link
Member

dsyer commented Jan 28, 2021

Some of this is interesting. I'm not sure we want the pom.xml change (we've discussed that before and concluded it should already be covered by the format plugin). The date format changes don't look like they would work ; and yyyy-MM-dd is an international date format anyway, so I'm not sure we need to change it. The net result of the i18n changes is that only English and Brazilian have a full set of messages? It might be better to leave the pt_BR messages in your fork and concentrate on better coverage for the languages that we already support.

@dsyer dsyer mentioned this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants