Adds a cacheInstanciatedViews property to SC.ContainerView #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't completely get what this achieves exactly. As far as I know, the containerView will used cached views as long as the views to display are contained in an SC.Page object. What does this solve on top of the SC.Page based caching? |
nicolasbadia
force-pushed
the
master
branch
7 times, most recently
from
045da60
to
2463b05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a simplier version of the
cachedViewLimitproperty from #1037It just add a
cacheInstanciatedViewsproperty which will cache views instanciated by the container when set to true (which is the default).As I believe an
SC.ContainerViewas a limited number of child, I believe this setting is far from enough.