Skip to content

Commit

Permalink
Make the MySQL checkit() function deterministic.
Browse files Browse the repository at this point in the history
Because it is, and @doy tells me that this gets it to install properly on
MariaDB. Ref Issue #158.
  • Loading branch information
theory committed Jun 3, 2014
1 parent 363dbef commit 18551f8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions Changes
Expand Up @@ -19,6 +19,9 @@ Revision history for Perl extension App::Sqitch
- Fix issue where, on first deploy, the MySQL engine would fail to notice
that the server was not the right version of MySQL. Thanks to Luke
Young for the report (Issue #158).
- Made the `checkit()` MySQL function DETERMINISTIC, to improve
compatability with MariaDB. Thanks to Jesse Luehrs for the report
(Issue #158).

0.992 2014-03-05T00:34:49Z
- Fixed target test failures on Windows.
Expand Down
2 changes: 1 addition & 1 deletion lib/App/Sqitch/Engine/mysql.sql
Expand Up @@ -137,7 +137,7 @@ CREATE TABLE events (

DELIMITER |

CREATE FUNCTION checkit(doit INTEGER, message VARCHAR(256)) RETURNS INTEGER
CREATE FUNCTION checkit(doit INTEGER, message VARCHAR(256)) RETURNS INTEGER DETERMINISTIC
BEGIN
IF doit IS NULL OR doit = 0 THEN
SIGNAL SQLSTATE 'ERR0R' SET MESSAGE_TEXT = message;
Expand Down

0 comments on commit 18551f8

Please sign in to comment.