fix: expected reward cycle in integration test for pox info #4488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kantai
approved these changes
Mar 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #4488 +/- ##
==========================================
- Coverage 82.95% 77.21% -5.74%
==========================================
Files 451 451
Lines 324490 324497 +7
Branches 318 318
==========================================
- Hits 269169 250561 -18608
- Misses 55313 73928 +18615
Partials 8 8
... and 175 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
neon_integrations::pox_integration_testhas been failing CI pretty consistently (but not 100%?), such as in this build: https://github.com/stacks-network/stacks-core/actions/runs/8161203003/job/22313964190?pr=4461This changes the test to not use hard-coded reward cycles that are expected, and instead to calculate the reward cycle from the current burnchain height.