fix: use testnet consts when generating xenon config #4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8marz8
approved these changes
Mar 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #4499 +/- ##
==========================================
- Coverage 83.23% 83.10% -0.13%
==========================================
Files 451 451
Lines 325724 325724
Branches 323 323
==========================================
- Hits 271125 270705 -420
- Misses 54591 55011 +420
Partials 8 8
... and 23 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing around with running a xenon node off of the
nextbranch (which I know won't work), and I caught a startup error that originates from validation of burnchain epochs. Looking in to the code, I caught that we were using mainnet consts instead of testnet consts.I know these consts will definitely change, but I'd still like to get this merged, because I'm trying to help signers get their infra setup. Even if their node doesn't sync any Stacks blocks, it would be helpful to not have a startup crash.