New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update signer logging to include reward cycle to differentiate curren… #4505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because I think it's better to merge now, but I think the size of the diff here demonstrates that it would be helpful to have some kind of log_label(signer)
helper. For example, it might also be prudent to log the pubkey or address
But that's a nit, this LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4505 +/- ##
==========================================
- Coverage 83.26% 82.44% -0.83%
==========================================
Files 452 452
Lines 326008 325964 -44
Branches 323 323
==========================================
- Hits 271444 268730 -2714
- Misses 54556 57226 +2670
Partials 8 8
... and 36 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes I considered this but assumed could be done later. Just did a quick search replace... But will do now as its also basically a quick search replace XD |
…t and next signers Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
de9494b
to
3022282
Compare
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
3022282
to
28bcd1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
added reward cycle to signer logs to differentiate between current and next reward cycle signer state machines