Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add signer-key to stack-increase event #4508

Merged
merged 1 commit into from Mar 8, 2024

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Mar 8, 2024

This does two things:

@hstove hstove linked an issue Mar 8, 2024 that may be closed by this pull request
@hstove
Copy link
Contributor Author

hstove commented Mar 8, 2024

This will conflict with #4414. I'm happy to add this to that PR or the opposite, just lmk @8marz8 @zone117x

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.21%. Comparing base (206ea63) to head (24af4a8).
Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4508      +/-   ##
==========================================
- Coverage   83.24%   83.21%   -0.03%     
==========================================
  Files         452      452              
  Lines      326005   326072      +67     
  Branches      323      323              
==========================================
- Hits       271373   271337      -36     
- Misses      54624    54727     +103     
  Partials        8        8              
Files Coverage Δ
pox-locking/src/events.rs 90.64% <100.00%> (+0.58%) ⬆️
...tackslib/src/chainstate/stacks/boot/pox_4_tests.rs 99.68% <100.00%> (+<0.01%) ⬆️

... and 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 206ea63...24af4a8. Read the comment docs.

Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hstove! This LGTM. I think we should merge it and rebase #4414

@hstove hstove added this pull request to the merge queue Mar 8, 2024
Merged via the queue into next with commit 755dd5f Mar 8, 2024
2 checks passed
@hstove hstove deleted the feat/stack-increase-events branch March 8, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Nakamoto] Include signer-key (and other args) in stack-increase events
3 participants