fix: try not deleting accepted blocks from signerDB #4514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dream-team-fixes #4514 +/- ##
====================================================
- Coverage 83.23% 82.83% -0.40%
====================================================
Files 452 452
Lines 326113 326161 +48
Branches 323 323
====================================================
- Hits 271436 270177 -1259
- Misses 54669 55976 +1307
Partials 8 8
... and 33 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
kantai
reviewed
Mar 9, 2024
Comment on lines
-995
to
+1000
| // TODO: proper garbage collection...This is currently our only cleanup of blocks | ||
| self.signer_db | ||
| .remove_block(&block_vote.signer_signature_hash) | ||
| .expect(&format!("{self}: Failed to remove block from to signer DB")); | ||
| // WIP: try not deleting a block from signerDB until we have a better garbage collection strategy. | ||
| // This causes issues when we have to reprocess a block and we have already deleted it from the signerDB | ||
| // // TODO: proper garbage collection...This is currently our only cleanup of blocks | ||
| // self.signer_db | ||
| // .remove_block(&block_vote.signer_signature_hash) | ||
| // .expect(&format!("{self}: Failed to remove block from to signer DB")); |
There was a problem hiding this comment.
Yep -- I'd advocate just dropping this line permanently (no need to comment out). Now that this information is stored in a file, I don't think that there's a strong need to clean this state up.
kantai
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In looking at testnet logs, I've seen that we hit scenarios where a block is saved as "accepted", which deletes the block from SignerDB, and then shortly later the signer tries to process the block, but the signer has no about the block (because it's deleted).