Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes / clean up #4516

Merged
merged 3 commits into from Mar 11, 2024
Merged

Minor changes / clean up #4516

merged 3 commits into from Mar 11, 2024

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Mar 11, 2024

No description provided.

@obycode obycode requested review from kantai and hstove March 11, 2024 15:44
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.04%. Comparing base (d1d1365) to head (6daf973).
Report is 11 commits behind head on dream-team-fixes.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           dream-team-fixes    #4516       +/-   ##
=====================================================
- Coverage             83.06%   66.04%   -17.02%     
=====================================================
  Files                   452      452               
  Lines                326161   326179       +18     
  Branches                323      323               
=====================================================
- Hits                 270912   215417    -55495     
- Misses                55241   110754    +55513     
  Partials                  8        8               
Files Coverage Δ
stacks-signer/src/runloop.rs 90.74% <100.00%> (-0.47%) ⬇️
testnet/stacks-node/src/nakamoto_node/miner.rs 80.43% <ø> (+0.14%) ⬆️

... and 257 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1c226c...6daf973. Read the comment docs.

@obycode obycode merged commit 52f2c99 into dream-team-fixes Mar 11, 2024
1 of 2 checks passed
@obycode obycode deleted the brice/minor-changes branch March 11, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants