Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add const to determine whether to rotate coordinator #4517

Merged
merged 1 commit into from Mar 11, 2024

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Mar 11, 2024

Added logic to use a const to determine whether to rotate coordinators when update_coordinator is called

@hstove hstove requested review from kantai and obycode March 11, 2024 17:20
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 43.75000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 83.15%. Comparing base (6daf973) to head (7891f7e).
Report is 1 commits behind head on dream-team-fixes.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           dream-team-fixes    #4517       +/-   ##
=====================================================
+ Coverage             72.05%   83.15%   +11.10%     
=====================================================
  Files                   452      452               
  Lines                326179   326180        +1     
  Branches                323      323               
=====================================================
+ Hits                 235021   271235    +36214     
+ Misses                91150    54937    -36213     
  Partials                  8        8               
Files Coverage Δ
stacks-signer/src/coordinator.rs 75.33% <43.75%> (+32.38%) ⬆️

... and 209 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52f2c99...7891f7e. Read the comment docs.

@hstove hstove merged commit 24a177d into dream-team-fixes Mar 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants