Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pox_stx_threshold amount to /new_block event data #4524

Merged
merged 5 commits into from Mar 13, 2024

Conversation

zone117x
Copy link
Member

Event indexers (e.g. the Stacks API) analyze historical pox-4 events to generate rich signer data. One of the challenges is determining which past stacking transactions should be considered for a given pox cycle. In this case, we want the ability to know if a historical pox-4 stacking event was discarded because of not meeting the minimum stx threshold (i.e. not given any slots/weight).

This PR adds the (stx) threshold value used for a given cycle's reward calculations to the /new_block event payload.

@zone117x zone117x enabled auto-merge March 12, 2024 17:28
obycode
obycode previously approved these changes Mar 12, 2024
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.41%. Comparing base (87c0c00) to head (d38a9e6).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4524      +/-   ##
==========================================
- Coverage   83.29%   82.41%   -0.88%     
==========================================
  Files         452      452              
  Lines      326071   326098      +27     
  Branches      323      323              
==========================================
- Hits       271594   268756    -2838     
- Misses      54469    57334    +2865     
  Partials        8        8              
Files Coverage Δ
stacks-signer/src/client/stacks_client.rs 87.25% <100.00%> (+0.01%) ⬆️
stackslib/src/chainstate/coordinator/tests.rs 90.79% <100.00%> (+<0.01%) ⬆️
stackslib/src/chainstate/stacks/boot/mod.rs 94.78% <100.00%> (+0.02%) ⬆️

... and 53 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87c0c00...d38a9e6. Read the comment docs.

hstove
hstove previously approved these changes Mar 12, 2024
@zone117x zone117x dismissed stale reviews from hstove and obycode via d38a9e6 March 13, 2024 09:22
@zone117x zone117x requested review from hstove and obycode March 13, 2024 09:23
@zone117x zone117x added this pull request to the merge queue Mar 13, 2024
Merged via the queue into next with commit fec1cb5 Mar 13, 2024
2 checks passed
@zone117x zone117x deleted the feat/add-pox-threshold-event-data branch March 13, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants