Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove --reward-cycle from stacks-signer run #4542

Merged
merged 1 commit into from Mar 15, 2024

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Mar 14, 2024

Right now, when running stacks-signer run ..., you need to include a --reward-cycle argument. This is actually now longer used, but it's still required, so all of our docs/infra just use --reward-cycle 1.

This PR separates the args for run and dkg, so that you no longer need to pass --reward-cycle to run.

I've also added the short macro to all --config args, so you can optionally use -c.

NB: this will break existing infra as well as some of our docs, so we need to be mindful of updating them once this is merged.

@hstove hstove requested review from obycode and jferrant March 14, 2024 18:10
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 83.35%. Comparing base (86fdb80) to head (f591098).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #4542   +/-   ##
=======================================
  Coverage   83.35%   83.35%           
=======================================
  Files         453      453           
  Lines      328034   328036    +2     
  Branches      323      323           
=======================================
+ Hits       273426   273437   +11     
+ Misses      54600    54591    -9     
  Partials        8        8           
Files Coverage Δ
stacks-signer/src/main.rs 36.02% <0.00%> (ø)
stacks-signer/src/cli.rs 32.55% <0.00%> (-0.52%) ⬇️

... and 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86fdb80...f591098. Read the comment docs.

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@jferrant jferrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hstove hstove enabled auto-merge March 15, 2024 14:14
@hstove hstove added this pull request to the merge queue Mar 15, 2024
Merged via the queue into next with commit 08ebb7f Mar 15, 2024
2 checks passed
@hstove hstove deleted the fix/remove-reward-cycle-arg branch March 15, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants