fix: isolate event-dispatcher serialization code #4545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4545 +/- ##
==========================================
- Coverage 83.34% 83.23% -0.12%
==========================================
Files 453 453
Lines 328342 328354 +12
Branches 323 323
==========================================
- Hits 273650 273292 -358
- Misses 54684 55054 +370
Partials 8 8
... and 36 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
zone117x
changed the title
zone117x
force-pushed
the
fix/rewarded_addresses-json-serialization
branch
from
91fd68f
to
9664056
Compare
hstove
previously approved these changes
Mar 15, 2024
hstove
approved these changes
Mar 18, 2024
kantai
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4492
Supersedes #4546
A few structs used in consensus critical or db migration critical areas were also being reused for serializing to JSON in the event dispatcher. Since then, several changes were made only for the event dispatcher JSON serialization, and in one case likely broke db migrations.
This PR moves the event-dispatcher-specific code out of those more core areas.