Feat/signers get round info and use it to determine if a vote has failed #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4569 +/- ##
==========================================
- Coverage 83.36% 82.43% -0.94%
==========================================
Files 456 470 +14
Lines 330480 332245 +1765
Branches 323 317 -6
==========================================
- Hits 275513 273871 -1642
- Misses 54959 58366 +3407
Partials 8 8
... and 368 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…rent vote weight consumed Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
…if it has Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
jferrant
force-pushed
the
feat/signers-get-round-info
branch
from
eae2f6e
to
ec500ba
Compare
hstove
previously approved these changes
Mar 27, 2024
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
obycode
approved these changes
Mar 28, 2024
kantai
approved these changes
Mar 28, 2024
jcnelson
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trigger a new DKG vote if a vote round has failed based on threshold being exceeded in the contract. Still need some sort of timeout logic in place for signers but this is a bigger question as we still haven't figure dout timeout logic for the coordinator itself.
Closes: #4419