Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary retries throughout code #4582

Closed
wants to merge 1 commit into from

Conversation

jferrant
Copy link
Collaborator

Was having a hard time following the retry logic throughout the stacks-signer. Have made it more explicit. Removing any outer retry calls unless trying to initialize/refresh the signer as a signer may be started before a node boots.

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant jferrant requested a review from hstove March 22, 2024 21:10
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 59.96%. Comparing base (441b7ed) to head (a70414f).

Additional details and impacted files
@@             Coverage Diff             @@
##             next    #4582       +/-   ##
===========================================
- Coverage   83.39%   59.96%   -23.44%     
===========================================
  Files         471      471               
  Lines      337957   337935       -22     
  Branches      317      317               
===========================================
- Hits       281855   202657    -79198     
- Misses      56094   135270    +79176     
  Partials        8        8               
Files Coverage Δ
stacks-signer/src/runloop.rs 77.88% <100.00%> (-12.37%) ⬇️
stacks-signer/src/client/stackerdb.rs 69.52% <80.00%> (-19.84%) ⬇️
stacks-signer/src/client/stacks_client.rs 67.35% <84.00%> (-20.07%) ⬇️
stacks-signer/src/signer.rs 62.20% <78.94%> (-10.29%) ⬇️

... and 324 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 441b7ed...a70414f. Read the comment docs.

@jferrant
Copy link
Collaborator Author

Replaced by #4583

@jferrant jferrant closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant