Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attempt to treat miner as a coordinator when updating DKG #4591

Merged
merged 9 commits into from Apr 3, 2024

Conversation

jferrant
Copy link
Collaborator

This only really matters for epoch 2.5. If this was to happen in epoch 3.0 the chain would be halted.

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant jferrant marked this pull request as ready for review March 25, 2024 23:06
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 82.81%. Comparing base (929a9b8) to head (4b26a2c).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4591      +/-   ##
==========================================
+ Coverage   77.90%   82.81%   +4.90%     
==========================================
  Files         470      470              
  Lines      332714   332704      -10     
  Branches      317      317              
==========================================
+ Hits       259201   275518   +16317     
+ Misses      73505    57178   -16327     
  Partials        8        8              
Files Coverage Δ
stacks-signer/src/main.rs 36.00% <ø> (+20.92%) ⬆️
stacks-signer/src/runloop.rs 91.08% <100.00%> (-1.28%) ⬇️
stacks-signer/src/signerdb.rs 90.98% <0.00%> (ø)
stacks-signer/src/coordinator.rs 78.16% <0.00%> (+23.06%) ⬆️
stacks-signer/src/signer.rs 72.81% <82.50%> (-0.79%) ⬇️

... and 186 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 929a9b8...4b26a2c. Read the comment docs.

jcnelson
jcnelson previously approved these changes Mar 26, 2024
stacks-signer/src/signer.rs Outdated Show resolved Hide resolved
Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay, but I think that this should be encapsulated in the Signer::get_coordinator() function.

…optionally

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
jcnelson
jcnelson previously approved these changes Mar 27, 2024
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…re appropro

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
obycode
obycode previously approved these changes Mar 28, 2024
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kantai
kantai previously approved these changes Mar 28, 2024
jcnelson
jcnelson previously approved these changes Mar 29, 2024
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just minor things

…into bugfix/enable-dkg-in-current-reward-cycle
@jferrant jferrant dismissed stale reviews from jcnelson and kantai via ca71d95 April 2, 2024 13:23
…into bugfix/enable-dkg-in-current-reward-cycle
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
jcnelson
jcnelson previously approved these changes Apr 3, 2024
stacks-signer/src/signer.rs Outdated Show resolved Hide resolved
obycode
obycode previously approved these changes Apr 3, 2024
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one accidental repeated log line.

kantai
kantai previously approved these changes Apr 3, 2024
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant jferrant dismissed stale reviews from kantai, obycode, and jcnelson via 803ab47 April 3, 2024 16:38
kantai
kantai previously approved these changes Apr 3, 2024
jcnelson
jcnelson previously approved these changes Apr 3, 2024
…into bugfix/enable-dkg-in-current-reward-cycle
@jferrant jferrant dismissed stale reviews from jcnelson and kantai via 4b26a2c April 3, 2024 18:25
@jferrant jferrant requested review from jcnelson and kantai April 3, 2024 18:25
@kantai kantai added this pull request to the merge queue Apr 3, 2024
Merged via the queue into next with commit 9708368 Apr 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants