New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not attempt to treat miner as a coordinator when updating DKG #4591
Conversation
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4591 +/- ##
==========================================
+ Coverage 77.90% 82.81% +4.90%
==========================================
Files 470 470
Lines 332714 332704 -10
Branches 317 317
==========================================
+ Hits 259201 275518 +16317
+ Misses 73505 57178 -16327
Partials 8 8
... and 186 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay, but I think that this should be encapsulated in the Signer::get_coordinator()
function.
…optionally Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…re appropro Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; just minor things
…into bugfix/enable-dkg-in-current-reward-cycle
…into bugfix/enable-dkg-in-current-reward-cycle
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just one accidental repeated log line.
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
…into bugfix/enable-dkg-in-current-reward-cycle
This only really matters for epoch 2.5. If this was to happen in epoch 3.0 the chain would be halted.