[~] Possible fix for private groups not showing. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will need to be tested, I cannot get statping to build.
|
Awesome. Will review and merge when we get time. |
|
Are there any updates on this? Would be great if it could be merged if this actually fixes the bug |
|
Hi, we just needs to test this, I'm cautious that we don't want to leak private data via any api calls. Our current test suite might not catch any leaks with this and I personally don't have any tools to test the api on a built version. We will eventually merge this once we're confident / it's reported to work without any data leaks by multiple people. |
ghost
closed this by deleting the head repository
|
I was unaware that this was still open. I can make another PR for this with new code again if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will need to be tested, I cannot get statping-ng to build.
Intended to fix #69 but I am not completely sure if it does. I tried a couple times to get this to build on my local environment but I just couldn't figure it out. If I could get some help with that, it would be great.