Allow the parent frame of a streamlit app to terminate/restart its websocket #8704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdonato
force-pushed
the
vdonato/host-websocket-msgs
branch
3 times, most recently
from
c657a18 to
96971e0
Compare
vdonato
commented
May 21, 2024
vdonato
force-pushed
the
vdonato/host-websocket-msgs
branch
2 times, most recently
from
72a5d25 to
b43e734
Compare
vdonato
changed the title
|
Heads up @sfc-gh-pfinnigan @sfc-gh-shaar that these message types should be ready for e2e testing in SiS. Note the names of the messages are currently:
but I'm not very opinionated on these names and am happy to change them if any better one are suggested. Also, I haven't started looking into websocket close codes or backoffs on ws reconnect retries just yet, but I'll be doing some investigation of those over the next few days. |
vdonato
force-pushed
the
vdonato/host-websocket-msgs
branch
from
b43e734 to
727dfc9
Compare
|
Temporarily adding the |
kmcgrady
reviewed
May 22, 2024
vdonato
force-pushed
the
vdonato/host-websocket-msgs
branch
5 times, most recently
from
c5304bb to
bb2fcbf
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
vdonato
force-pushed
the
vdonato/host-websocket-msgs
branch
3 times, most recently
from
e7ecf74 to
aaeabe2
Compare
raethlein
approved these changes
Jun 12, 2024
mayagbarnes
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Would also really appreciate it if you could add these messages to our Host <-> Guest documentation here with some context!
vdonato
force-pushed
the
vdonato/host-websocket-msgs
branch
from
aaeabe2 to
96d3e12
Compare
vdonato
force-pushed
the
vdonato/host-websocket-msgs
branch
from
96d3e12 to
108093e
Compare
benjamin-awd
pushed a commit
to benjamin-awd/streamlit
that referenced
this pull request
Sep 29, 2024
…bsocket (streamlit#8704) We want to be able to let the parent frame of a streamlit app manage its websocket connection lifecycle. This PR adds this functionality to our `HostCommunicationManager` class by adding four new message types for interacting with a Streamlit app's websocket connection: * `RESTART_WEBSOCKET_CONNECTION` * `TERMINATE_WEBSOCKET_CONNECTION` * `WEBSOCKET_DISCONNECTED` (along with an attemptingToReconnect flag in the message payload) * `WEBSOCKET_CONNECTED`
edegp
pushed a commit
to edegp/streamlit
that referenced
this pull request
Jan 19, 2025
…bsocket (streamlit#8704) We want to be able to let the parent frame of a streamlit app manage its websocket connection lifecycle. This PR adds this functionality to our `HostCommunicationManager` class by adding four new message types for interacting with a Streamlit app's websocket connection: * `RESTART_WEBSOCKET_CONNECTION` * `TERMINATE_WEBSOCKET_CONNECTION` * `WEBSOCKET_DISCONNECTED` (along with an attemptingToReconnect flag in the message payload) * `WEBSOCKET_CONNECTED`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to let the parent frame of a streamlit app manage its websocket connection
lifecycle. This PR adds this functionality to our
HostCommunicationManagerclass by adding fournew message types for interacting with a Streamlit app's websocket connection:
RESTART_WEBSOCKET_CONNECTIONTERMINATE_WEBSOCKET_CONNECTIONWEBSOCKET_DISCONNECTED(along with an attemptingToReconnect flag in the message payload)WEBSOCKET_CONNECTED