Support API 2020-03-02 #710
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coorasse
commented
Mar 19, 2020
| @@ -6,17 +6,18 @@ rvm: | |||
| - 2.4.6 | |||
| - 2.5.5 | |||
| - 2.6.3 | |||
| before_install: | |||
There was a problem hiding this comment.
this was simply not necessary
| - STRIPE_TEST_SECRET_KEY_A=sk_test_BsztzqQjzd7lqkgo1LjEG5DF00KzH7tWKF | ||
| matrix: | ||
| - STRIPE_API_VERSION=2020-03-02 | ||
|
|
There was a problem hiding this comment.
now, we can run the tests on different versions by simply adding it to the matrix, currently, I want to support only the latest, I haven't checked with older versions. No need for multiple keys anymore (see comment on spec_helper.rb later)
| @@ -3,7 +3,7 @@ module RequestHandlers | |||
| module ParamValidators | |||
|
|
|||
| def already_exists_message(obj_class) | |||
| "#{obj_class.to_s.split("::").last} already exists." | |||
| /#{obj_class.to_s.split("::").last.downcase} already exists./i | |||
There was a problem hiding this comment.
relax it a bit. is different in some requests
| @@ -149,7 +149,7 @@ | |||
| 255.times { data << Stripe::Charge.create(amount: 1, currency: 'usd', source: stripe_helper.generate_card_token) } | |||
| list = StripeMock::Data::List.new(data, starting_after: "test_ch_unknown") | |||
|
|
|||
| expect { list.to_h }.to raise_error | |||
| expect { list.to_h }.to raise_error(RuntimeError) | |||
| end | ||
|
|
||
| c.before(:each) do | ||
| allow(StripeMock).to receive(:start).and_return(nil) | ||
| allow(StripeMock).to receive(:stop).and_return(nil) | ||
| Stripe.api_key = api_key | ||
| Stripe.api_version = ENV['STRIPE_API_VERSION'] |
There was a problem hiding this comment.
Here we can set and test against different API versions. The library might also use Stripe.api_version to be retro-compatible (not necessary imho).
|
👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR is to improve and fix the Travis build, currently failing, and also run the tests against the latest Stripe version.
This forced me to make also some changes to the code.
Please read my comments within the PR.
I think it might bring some breaking changes.
I thought you were using different Stripe Api Keys to test against different API versions, but I see now that is to be able to run parallel builds. Do you want to keep that? I can re-introduce it.