Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send filename when creating and updating styles #861

Merged
merged 1 commit into from Mar 18, 2024
Merged

Conversation

edsu
Copy link
Contributor

@edsu edsu commented Mar 15, 2024

Why was this change made? 馃

Calling Style.create without a filename causes Geoserver to throw a 500 error. This commit supplies a filename using the layer name + the ".sld" extension.

Fixes #860

How was this change tested? 馃え

Running unit tests, and running the data through Preassembly in Stage and confirming it made it through accessioning. https://argo-stage.stanford.edu/view/druid:rz417vq6403

@edsu edsu changed the title Send filename when creating and updating Send filename when creating and updating styles Mar 15, 2024
@edsu edsu changed the title Send filename when creating and updating styles [HOLD] Send filename when creating and updating styles Mar 15, 2024
Calling [Style.create](https://github.com/samvera-labs/geoserver-publish/blob/aec7c64311a17e2e948dd43b6523fdcc604d2837/lib/geoserver/publish/style.rb#L28-L32) without a filename causes Geoserver to throw a 500 error. This commit supplies a filename using the layer name + the ".sld" extension.

Fixes #860
@edsu edsu changed the title [HOLD] Send filename when creating and updating styles Send filename when creating and updating styles Mar 18, 2024
@ndushay ndushay merged commit 1fe5b44 into main Mar 18, 2024
5 checks passed
@ndushay ndushay deleted the style-changes branch March 18, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geoserver 500 error when creating style in load_geoserver
3 participants