add a new gis raster integration test #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peetucket
commented
Mar 6, 2024
| # a zipped copy is available at spec/fixtures/gis_integration_test_data.zip | ||
| test_data_source_folder = File.join(Settings.gis.robots_content_root, 'integration_test_data') | ||
| # a zipped copy is available at spec/fixtures/gis_integration_test_data_vector.zip | ||
| test_data_source_folder = File.join(Settings.gis.robots_content_root, 'integration_test_data_vector') | ||
| test_data_destination_folder = File.join(DruidTools::Druid.new(druid, Settings.gis.robots_content_root).path, 'content') |
There was a problem hiding this comment.
new folder name for this existing test data to distinguish from raster based test data
peetucket
commented
Mar 6, 2024
| expect(page).to have_no_text(object_label) # the original object label has been replaced | ||
| expect(page).to have_text('Air Monitoring Stations: California, 2001-2003') # with the new object label | ||
| expect(page).to have_text('This point shapefile represents all air monitoring stations active in ' \ | ||
| 'California from 2001 until 2003') # abstract | ||
| expect(page).to have_text('cartographic') # type of resource |
There was a problem hiding this comment.
we don't need to use expect_text_on_purl_page method, since this just makes an unnecessary reload of the PURL page
peetucket
commented
Mar 6, 2024
| expect(page).to have_no_text(object_label) # the original object label has been replaced | ||
| expect(page).to have_text('Air Monitoring Stations: California, 2001-2003') # with the new object label | ||
| expect(page).to have_text('This point shapefile represents all air monitoring stations active in ' \ | ||
| 'California from 2001 until 2003') # abstract | ||
| expect(page).to have_text('cartographic') # type of resource |
There was a problem hiding this comment.
we don't need to use expect_text_on_purl_page method, since this just makes an unnecessary reload of the PURL page
aaron-collier
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made? 馃
Fixes #699 - add a GIS integration test for raster based objects
Confirmed on localhost running all GIS tests on stage.
Note that I only made a new GIS pre-assembly raster spec, since that is adequate to confirm it works (no need to also do a new manual GIS integration test with raster data that does it the manual way, since the actual accessioning workflows are the same once you get past pre-assembly).
NOTE: once merged, we can remove the folder
/gis_workflow_data/stage/integration_test_dataonkurma-robots-stage-01.stanford.edusince that has been copied to/gis_workflow_data/stage/integration_test_data_vector